fix(monorepo): ignore unnessary react peers from antd #3487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0f88b7b The changes in this PR will be included in the next version bump. This PR includes changesets to release 212 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
chenjiahan
previously approved these changes
Apr 18, 2023
|
@JSerFeng CI is failed |
JSerFeng
force-pushed
the
fix/peer
branch
4 times, most recently
from
0a616e5
to
e3eb104
Compare
chenjiahan
previously approved these changes
Apr 19, 2023
|
snapshot failed~ |
* fix(app-tools): can not disable cleanDistPath * chore: update test case * chore: add changeset
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3487 +/- ##
==========================================
+ Coverage 57.59% 57.88% +0.28%
==========================================
Files 672 653 -19
Lines 17794 17175 -619
Branches 3876 3745 -131
==========================================
- Hits 10249 9942 -307
+ Misses 6934 6634 -300
+ Partials 611 599 -12
... and 119 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
chenjiahan
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
antddependency has peer dependencies for react andreact-dom, however sometimes we just needantdto be resolved, instead of using it directly, so we don't need to install its peer deps.Vitest based tests that don't really need antd, using spyOn to mock the require of
antd.Playwright test in e2e don't have mock API, so install react for it.
🤖 Generated by Copilot at 1f915f5
Removed
antdfrom the dependencies of three builder packages and usedvitestto mock its presence in the tests. Addedreactandreact-domto the test cases that import different versions ofantd. This is to avoid dependency conflicts and test the compatibility of the packages with variousantdversions.Details
🤖 Generated by Copilot at 1f915f5
antddependency frompackages/builder/builder-rspack-provider/package.json,packages/builder/builder-webpack-provider/package.json, andpackages/builder/plugin-swc/package.jsonto avoid conflicts with different versions ofantdin the tests (link, link, link)requireandrequire.resolvefunctions intests/setup.tsfiles of the above packages usingviobject fromvitestto simulate the presence ofantdversion 4 in the node_modules of the test cases that use these packages, without actually installing it as a dependency (link, link, link)reactandreact-domdependencies totests/e2e/builder/cases/import-antd-v4/package.jsonandtests/e2e/builder/cases/import-antd-v5/package.jsonbecause they are peer dependencies ofantdversion 4 and 5 respectively and they are needed to run the test cases (link, link)Related Issue
Checklist
pnpm run change.