New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(app-tools): failed to validate globalVars in legacy mode #3508
Merged
chenjiahan
merged 1 commit into
web-infra-dev:main
from
chenjiahan:legacy_global_vars_0420
Apr 20, 2023
Merged
fix(app-tools): failed to validate globalVars in legacy mode #3508
chenjiahan
merged 1 commit into
web-infra-dev:main
from
chenjiahan:legacy_global_vars_0420
Apr 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
馃 Changeset detectedLatest commit: d559822 The changes in this PR will be included in the next version bump. This PR includes changesets to release 212 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
yimingjfe
approved these changes
Apr 20, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
馃 Generated by Copilot at d559822
This pull request fixes a bug and adds a feature to the
@modern-js/app-tools
package. It allows theglobalVars
option to be a function and validates it correctly. It also updates the changeset file with the patch version and the fix message.Details
馃 Generated by Copilot at d559822
globalVars
option to be a function and fix validation bug in legacy mode of@modern-js/app-tools
(link)@modern-js/app-tools
(link)Related Issue
Checklist
pnpm run change
.