Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(module-doc): add basic test case for module doc #3998

Merged
merged 1 commit into from
Jun 20, 2023

Conversation

10Derozan
Copy link
Member

@10Derozan 10Derozan commented Jun 16, 2023

Summary

🤖 Generated by Copilot at 4526cbd

This pull request adds integration tests for the module-doc example app using puppeteer. It also updates the tsconfig.json file to include the tests folder.

Details

🤖 Generated by Copilot at 4526cbd

  • Add a new test file tests/basic.test.ts to check the rendering of the module-doc example app in development mode (link)

Related Issue

Checklist

  • I have added changeset via pnpm run change.
  • I have updated the documentation.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Jun 16, 2023

⚠️ No Changeset found

Latest commit: 4526cbd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.23 ⚠️

Comparison is base (99693f0) 57.59% compared to head (4526cbd) 57.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3998      +/-   ##
==========================================
- Coverage   57.59%   57.37%   -0.23%     
==========================================
  Files         672      645      -27     
  Lines       17794    17516     -278     
  Branches     3876     3833      -43     
==========================================
- Hits        10249    10049     -200     
+ Misses       6934     6843      -91     
- Partials      611      624      +13     

see 321 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@chenjiahan chenjiahan merged commit ae16058 into main Jun 20, 2023
8 checks passed
@chenjiahan chenjiahan deleted the tests/module-doc branch June 20, 2023 06:12
chenjiahan added a commit to chenjiahan/modern.js that referenced this pull request Jun 20, 2023
10Derozan added a commit that referenced this pull request Jul 11, 2023
chenjiahan pushed a commit that referenced this pull request Jul 11, 2023
…e char (#4182)

* fix(doc-core): can not find path only in windows bacause of the escape char

* Revert "Revert "test(module-doc): add basic test case for module doc (#3998)" (#4027)"

This reverts commit 6e2119e.

* chore: add changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants