Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: document support Sandpack component #4551

Merged
merged 8 commits into from
Sep 5, 2023
Merged

Conversation

caohuilin
Copy link
Member

@caohuilin caohuilin commented Aug 30, 2023

Summary

🤖 Generated by Copilot at c552877

This pull request adds a new feature to the @modern-js/sandpack-react package, which allows the documentation website of the modern.js framework to render interactive code examples using the sandpack library. It also refactors the logic of updating the package.json file of the target project in the module and mwa generators in the @modern-js/generator package, using handlebars templates instead of JSON API methods. Additionally, it fixes some typos in the template folder paths in the base generator and renames some template files for consistency. Finally, it adds some changeset files and an ESLint configuration file for the @modern-js/sandpack-react package.

Details

🤖 Generated by Copilot at c552877

  • Add @modern-js/sandpack-react package and custom component to render interactive code examples for documentation website (link, link, link, link)
  • Fix typos in base template and pnpm template paths in base generator class (link, link)
  • Refactor logic of updating package.json file for target project using handlebars templates instead of JSON API methods in module generator and mwa generator (link, link, link, link, link, link, link, link, link, link)
  • Add ESLint configuration file for @modern-js/sandpack-react package (link)
  • Rename base template and pnpm template files in base generator folder (link, link, link, link, link, link, link)

Related Issue

Checklist

  • I have added changeset via pnpm run change.
  • I have updated the documentation.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Aug 30, 2023

🦋 Changeset detected

Latest commit: 6a652be

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage has no change and project coverage change: -3.76% ⚠️

Comparison is base (99693f0) 57.59% compared to head (36f7632) 53.84%.
Report is 1096 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4551      +/-   ##
==========================================
- Coverage   57.59%   53.84%   -3.76%     
==========================================
  Files         672      657      -15     
  Lines       17794    17986     +192     
  Branches     3876     4149     +273     
==========================================
- Hits        10249     9685     -564     
- Misses       6934     7645     +711     
- Partials      611      656      +45     

see 456 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caohuilin caohuilin force-pushed the feat-sandpack-template branch 2 times, most recently from 6dbe97e to 9fc3a26 Compare September 4, 2023 08:27
@caohuilin caohuilin changed the title [WIP] feat: document support Sandpack component feat: document support Sandpack component Sep 4, 2023
@caohuilin caohuilin enabled auto-merge (squash) September 5, 2023 05:37
@caohuilin caohuilin merged commit f0c6df5 into main Sep 5, 2023
9 checks passed
@caohuilin caohuilin deleted the feat-sandpack-template branch September 5, 2023 05:42
@caohuilin caohuilin mentioned this pull request Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants