Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ssr-preload-include support specify rel #4568

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

GiveMe-A-Name
Copy link
Member

@GiveMe-A-Name GiveMe-A-Name commented Sep 4, 2023

Summary

🤖 Generated by Copilot at 521a707

This pull request adds support for specifying the rel attribute for the ssr-preload.include option in the @modern-js/prod-server and @modern-js/server-core packages. This allows users to customize the preload links for server-side rendering. The pull request also updates the type definitions, the logic for transforming links to strings, and the test case for the new features. It also adds a changeset file to document the minor version updates.

Details

🤖 Generated by Copilot at 521a707

  • Add a changeset file to document the minor version updates and new features for the @modern-js/prod-server and @modern-js/server-core packages (link)
  • Modify the type definition of the PreloadInclude type in the @modern-js/server-core package to allow an optional rel property for each include item (link)
  • Modify the type definition of the Link interface and the transformLinks2String function in the @modern-js/prod-server package to handle the rel and rest properties of the link objects (link, link)
  • Modify the test case for the transformLinks2String function in the @modern-js/prod-server package to cover the new features (link)

Related Issue

Checklist

  • I have added changeset via pnpm run change.
  • I have updated the documentation.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Sep 4, 2023

🦋 Changeset detected

Latest commit: 521a707

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 253 packages
Name Type
@modern-js/prod-server Minor
@modern-js/server-core Minor
@modern-js/plugin-ssg Minor
@modern-js/plugin-testing Minor
@modern-js/plugin-worker Minor
@modern-js/server Minor
@modern-js/builder-shared Minor
@modern-js/app-tools Minor
@modern-js/plugin-bff Minor
@modern-js/plugin-data-loader Minor
@modern-js/runtime Minor
@modern-js/plugin-express Minor
@modern-js/plugin-koa Minor
@modern-js/plugin-polyfill Minor
@modern-js/plugin-server Minor
@modern-js/server-utils Minor
server-config Minor
tests Minor
api-service-koa Minor
@modern-js/builder-rspack-provider Minor
@modern-js/builder-webpack-provider Minor
@modern-js/core Minor
@modern-js/plugin-storybook Minor
@modern-js/plugin-swc Minor
@modern-js/builder-cli Minor
@modern-js/builder Minor
@modern-js/friendly-errors-webpack-plugin Minor
@modern-js/builder-plugin-esbuild Minor
@modern-js/builder-plugin-node-polyfill Minor
@modern-js/builder-plugin-stylus Minor
@modern-js/builder-plugin-swc Minor
@modern-js/builder-plugin-vue Minor
@modern-js/builder-plugin-vue2 Minor
@e2e/builder Minor
@modern-js/plugin-tailwindcss Minor
@modern-js/devtools-client Minor
@modern-js/devtools-mount Minor
@modern-js/plugin-devtools Minor
@modern-js/plugin-garfish Minor
@modern-js/plugin-router-v5 Minor
@integration-test/alias-set Minor
app-docmuent Minor
integration-asset-prefix Minor
async-entry-test Minor
bff-express Minor
bff-koa Minor
integration-builder-plugins Minor
builder-rspack Minor
integration-clean-dist-path Minor
integration-compatibility Minor
integration-copy-assets Minor
integration-custom-render Minor
integration-custom-template Minor
dev-server Minor
@integration-test/devtools Minor
integration-disable-html Minor
legacy-esbuild-minify-js Minor
esbuild-transform-and-minify Minor
integration-config-async-config-test Minor
integration-basic-local-config Minor
integration-config-function-params Minor
integration-local-config-function Minor
main-entry-name Minor
tmp Minor
nonce Minor
routes Minor
file-based-router Minor
use-loader Minor
select-mul-entry-test Minor
select-one-entry-test Minor
server-middleware Minor
server-hook-reqeust Minor
server-hook-response Minor
server-hook-router Minor
@integration-test/server-hook-reqeust Minor
server-prod Minor
@source-code-build/app-ts-loader Minor
@source-code-build/app Minor
ssg-fixtures-nested-routes Minor
ssg-fixtures-simple Minor
ssg-fixtures-web-server Minor
ssr-base-json-test Minor
ssr-base-test Minor
ssr-base-fallback-test Minor
init Minor
ssr-preload Minor
ssr-streaming-test Minor
swc-minify-css Minor
swc-minify-js Minor
transform-fail Minor
integration-tailwindcss-v2 Minor
integration-tailwindcss-v3-js-config Minor
integration-tailwindcss-v3-merge-config Minor
integration-tailwindcss-v3-ts-config Minor
integration-tailwindcss-v3 Minor
twin-macro-v2 Minor
twin-macro-v3 Minor
tmp-dir Minor
write-to-dist Minor
@e2e/garfish-dashboard-router-v6 Minor
@e2e/garfish-dashboard Minor
@e2e/garfish-main-router-v6 Minor
@e2e/garfish-main Minor
@e2e/garfish-table Minor
@e2e/builder-cli-rspack Minor
@e2e/builder-cli-vue Minor
@modern-js/builder-plugin-image-compress Minor
@modern-js/module-tools Minor
@e2e/builder-cli-webpack Minor
@modern-js/babel-preset-app Minor
@modern-js/babel-preset-base Minor
@modern-js/doc-plugin-auto-sidebar Minor
@modern-js/plugin-changeset Minor
@modern-js/plugin-i18n Minor
@modern-js/plugin-lint Minor
@modern-js/plugin-proxy Minor
@modern-js/builder-doc Minor
@modern-js/main-doc Minor
@modern-js/module-tools-docs Minor
@modern-js/new-action Minor
@modern-js-app/eslint-config Minor
@modern-js/eslint-config Minor
@modern-js/tsconfig Minor
@modern-js/babel-plugin-module-resolver Minor
@modern-js/bff-core Minor
@modern-js/bff-runtime Minor
@modern-js/create-request Minor
@modern-js/libuild Minor
@modern-js/libuild-plugin-babel Minor
@modern-js/libuild-plugin-node-polyfill Minor
@modern-js/libuild-plugin-svgr Minor
@modern-js/libuild-plugin-swc Minor
@modern-js/libuild-utils Minor
@modern-js/plugin-module-babel Minor
@modern-js/plugin-module-banner Minor
@modern-js/plugin-module-doc Minor
@modern-js/plugin-module-import Minor
@modern-js/plugin-module-main-fields Minor
@modern-js/plugin-module-node-polyfill Minor
@modern-js/plugin-module-polyfill Minor
@modern-js/plugin-module-target Minor
@modern-js/monorepo-tools Minor
@modern-js/create Minor
@modern-js/e2e Minor
@modern-js/monorepo-utils Minor
@modern-js/node-bundle-require Minor
@modern-js/plugin Minor
@modern-js/types Minor
@modern-js/upgrade Minor
@modern-js/utils Minor
@modern-js/babel-compiler Minor
@scripts/build Minor
@scripts/check-changeset Minor
@scripts/jest-config Minor
@scripts/lint-package-json Minor
@scripts/prebundle Minor
@scripts/update-codesmith Minor
@scripts/vitest-config Minor
esbuild-integration Minor
browser-test Minor
lib1 Minor
lib2 Minor
lib3 Minor
antd-mobile Minor
mylib Minor
libuild-test Minor
integration-load-config Minor
integration-module-doc Minor
integration-module-tools Minor
alias-js-test Minor
alias-ts-test Minor
asset-path-test Minor
auto-external-test Minor
build-platform-test Minor
build-preset-error-test Minor
build-preset-function-test Minor
build-preset-test Minor
build-preset-string-test Minor
build-type-test Minor
copy-test Minor
decorator-test Minor
design-system-test Minor
dev-test Minor
dts-test Minor
entry-test Minor
esbuild-options-test Minor
external-test Minor
format-cjs-test Minor
format-esm-test Minor
format-iife-test Minor
format-umd-test Minor
global-vars-js-test Minor
global-vars-ts-test Minor
input-filter-test Minor
jsx-test Minor
metafile-test Minor
minify-test Minor
platform-test Minor
redirect-test Minor
module-tools-side-effects-test Minor
source-dir-test Minor
sourcemap-test Minor
splitting-test Minor
svgr-test Minor
target-test Minor
tools-test Minor
transform-lodash Minor
umdGlobals-test Minor
get-module-id-test Minor
builder-test Minor
build-watch-test Minor
runtime Minor
entry Minor
@source-code-build/common Minor
@source-code-build/components Minor
@source-code-build/utils Minor
ssg Minor
ssr Minor
swc-integration Minor
tailwindcss-integration-test Minor
@e2e/webpack-builder-import-antd-v4 Minor
@e2e/webpack-builder-import-antd-v5 Minor
@e2e/webpack-builder-import-arco Minor
@e2e/webpack-builder-test-moment Minor
@e2e/builder-remove-prop-types Minor
@e2e/builder-vue3 Minor
@e2e/builder-vue2 Minor
@e2e/garfish Minor
@modern-js/generator-common Patch
@modern-js/generator-plugin Patch
@modern-js/generator-utils Patch
@modern-js/bff-generator Patch
@modern-js/dependence-generator Patch
@modern-js/entry-generator Patch
@modern-js/generator-generator Patch
@modern-js/module-generator Patch
@modern-js/module-test-generator Patch
@modern-js/monorepo-generator Patch
@modern-js/mwa-generator Patch
@modern-js/router-v5-generator Patch
@modern-js/rspack-generator Patch
@modern-js/ssg-generator Patch
@modern-js/storybook-generator Patch
@modern-js/test-generator Patch
@modern-js/upgrade-generator Patch
@modern-js/generator-plugin-plugin Patch
@modern-js/repo-generator Patch
@modern-js/generator-cases Patch
@modern-js/base-generator Patch
@modern-js/changeset-generator Patch
@modern-js/packages-generator Patch
@modern-js/server-generator Patch
@modern-js/tailwindcss-generator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Patch coverage has no change and project coverage change: -3.81% ⚠️

Comparison is base (99693f0) 57.59% compared to head (521a707) 53.79%.
Report is 1088 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4568      +/-   ##
==========================================
- Coverage   57.59%   53.79%   -3.81%     
==========================================
  Files         672      655      -17     
  Lines       17794    17972     +178     
  Branches     3876     4145     +269     
==========================================
- Hits        10249     9668     -581     
- Misses       6934     7647     +713     
- Partials      611      657      +46     

see 452 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GiveMe-A-Name GiveMe-A-Name merged commit 5240e5d into main Sep 4, 2023
10 checks passed
@GiveMe-A-Name GiveMe-A-Name deleted the feat/ssr-preload-support-specify-rel branch September 4, 2023 05:43
@caohuilin caohuilin mentioned this pull request Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants