-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(generator): remove the default .idea config files #4583
Conversation
🦋 Changeset detectedLatest commit: ff30933 The changes in this PR will be included in the next version bump. This PR includes changesets to release 252 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4583 +/- ##
==========================================
- Coverage 57.59% 54.09% -3.51%
==========================================
Files 672 651 -21
Lines 17794 17899 +105
Branches 3876 4125 +249
==========================================
- Hits 10249 9682 -567
- Misses 6934 7565 +631
- Partials 611 652 +41 ☔ View full report in Codecov by Sentry. |
Summary
Remove the default .idea config files, because:
.idea
is added to.gitignore
by default, so these files cannot be shared.🤖 Generated by Copilot at ff30933
This pull request fixes the issue of generating unnecessary
.idea
config files for the IDE by default in the@modern-js/base-generator
package. It deletes thetemplates/idea
folder and its contents, and removes the code that copies it to the generated project. It also adds a changeset file to document the patch update.Details
🤖 Generated by Copilot at ff30933
.idea
config files frombase-generator
(link, link, link, link, link)@modern-js/base-generator
package (link)Related Issue
Checklist
pnpm run change
.