fix: lazy import preload, then update include.type to include.as #4589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6bb0e46 The changes in this PR will be included in the next version bump. This PR includes changesets to release 253 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
yimingjfe
approved these changes
Sep 6, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4589 +/- ##
==========================================
- Coverage 57.59% 54.07% -3.53%
==========================================
Files 672 652 -20
Lines 17794 17902 +108
Branches 3876 4128 +252
==========================================
- Hits 10249 9680 -569
- Misses 6934 7570 +636
- Partials 611 652 +41 ☔ View full report in Codecov by Sentry. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
unuse preload, but it would run some effect actions.
🤖 Generated by Copilot at 6bb0e46
This pull request improves and fixes the preload feature of the
@modern-js/prod-serverpackage, which allows the server to send preload hints to the browser for faster loading of resources. It changes the type definition, the file structure, and the import paths for the preload-related functions and types. It also updates the tests and the changelogs for the affected packages.Details
🤖 Generated by Copilot at 6bb0e46
@modern-js/prod-serverand@modern-js/server-corepackages (link)PreloadIncludetype to useasinstead oftypefor the preload links, and update theRoutestype accordingly inpackages/server/core/src/types/config/server.ts(link)shouldFlushServerHeaderfunction to a separate filepackages/server/prod-server/src/libs/preload/shouldFlushServerHeader.tsto isolate the preload condition logic (link, link)shouldFlushServerHeaderfunction inpackages/server/prod-server/src/libs/preload/transformLinks2String.tsandpackages/server/prod-server/src/libs/render/index.tsto use the new file path (link, link)flushServerHeaderfunction inpackages/server/prod-server/src/libs/render/index.tsto optimize the server loading time (link, link)addIncludefunction and the test case inpackages/server/prod-server/src/libs/preload/transformLinks2String.tsandpackages/server/prod-server/tests/preload.test.tsto useasinstead oftypefor the preload links (link, link)tests/integration/ssr/fixtures/preload/modern.config.tsto use theincludeoption and theasproperty (link)Related Issue
Checklist
pnpm run change.