-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(rspack): use DataURI module instead of rspack-plugin-virtual-module #4644
Conversation
🦋 Changeset detectedLatest commit: 949acd5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 253 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4644 +/- ##
==========================================
- Coverage 57.59% 53.57% -4.02%
==========================================
Files 672 665 -7
Lines 17794 18123 +329
Branches 3876 4157 +281
==========================================
- Hits 10249 9710 -539
- Misses 6934 7755 +821
- Partials 611 658 +47 ☔ View full report in Codecov by Sentry. |
…o chore/data-uri-module
Summary
🤖 Generated by Copilot at 35e37fe
This pull request refactors and simplifies the code for injecting core-js polyfills into the bundler chain for different providers. It uses a shared utility function from the
@modern-js/builder-shared
package and theDataURI
module to create virtual modules. It also updates the test case for the polyfill functionality and removes some unused dependencies.Details
🤖 Generated by Copilot at 35e37fe
@modern-js/builder-rspack-provider
and@modern-js/app-tools
packages (link)rspack-plugin-virtual-module
with theDataURI
module for creating virtual modules in the@modern-js/builder-rspack-provider
package (link, link, link)addCoreJsEntry
function from the@modern-js/builder-webpack-provider
package to the@modern-js/builder-shared
package and use it in both the webpack and the rspack providers to add a core-js entry to the bundler chain (link, link, link, link, link, link)@modern-js/builder-webpack-provider
and@modern-js/app-tools
packages (link, link)polyfill
test case to use therunServer
option of thebuild
function and thepage
object of playwright to check the polyfill effect in the browser (link, link, link, link, link)Related Issue
Checklist
pnpm run change
.