-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: the server need use headersSent without use flushHeader #4660
Conversation
🦋 Changeset detectedLatest commit: 71a1442 The changes in this PR will be included in the next version bump. This PR includes changesets to release 255 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4660 +/- ##
==========================================
- Coverage 57.59% 53.74% -3.86%
==========================================
Files 672 664 -8
Lines 17794 18093 +299
Branches 3876 4144 +268
==========================================
- Hits 10249 9724 -525
- Misses 6934 7712 +778
- Partials 611 657 +46 ☔ View full report in Codecov by Sentry. |
Summary
🤖 Generated by Copilot at b86a0de
This pull request fixes a bug in the
@modern-js/prod-server
package that caused errors when the server tried to flush headers manually. It adds a newflushedHeaders
property to the response object and updates theisSend
method to use it. It also updates the changelog and the type definitions accordingly.Details
🤖 Generated by Copilot at b86a0de
@modern-js/prod-server
package with bug fixes (link)flushedHeaders
property to response object to indicate header flushing status (link, link)flushedHeaders
andheadersSent
properties to check if response is sent inisSend
method ofModernServer
class (link)flushServerHeader
function inprod-server/src/libs/preload/flushServerHeader.ts
(link)Related Issue
Checklist
pnpm run change
.