-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ssr style link should not add scriptLoading attributes #4676
Conversation
🦋 Changeset detectedLatest commit: ef41885 The changes in this PR will be included in the next version bump. This PR includes changesets to release 255 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4676 +/- ##
==========================================
- Coverage 57.59% 53.74% -3.86%
==========================================
Files 672 664 -8
Lines 17794 18092 +298
Branches 3876 4143 +267
==========================================
- Hits 10249 9723 -526
- Misses 6934 7712 +778
- Partials 611 657 +46 ☔ View full report in Codecov by Sentry. |
Summary
🤖 Generated by Copilot at ef41885
This pull request fixes a bug in the server-side rendering of loadable components with
@modern-js/runtime
. It prevents adding unnecessary scriptLoading attributes to style and invalid chunks, and updates the package version and changelog.Details
🤖 Generated by Copilot at ef41885
loadable.ts
(link)@modern-js/runtime
package in.changeset/pink-teachers-hug.md
(link)Related Issue
Checklist
pnpm run change
.