-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(builder): mismatched directory name containing node_modules #4720
fix(builder): mismatched directory name containing node_modules #4720
Conversation
🦋 Changeset detectedLatest commit: 640aac1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 259 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4720 +/- ##
==========================================
- Coverage 57.59% 50.86% -6.74%
==========================================
Files 672 690 +18
Lines 17794 19207 +1413
Branches 3876 4443 +567
==========================================
- Hits 10249 9769 -480
- Misses 6934 8689 +1755
- Partials 611 749 +138 ☔ View full report in Codecov by Sentry. |
Summary
The RegExp should not match paths such as
test_node_moudules/src/index.ts
.🤖 Generated by Copilot at 640aac1
This pull request improves the code quality and the documentation of the source code referencing feature. It refactors the use of a node_modules regular expression to a shared constant in
babel.ts
andinspector.ts
, and adds a changeset file for the fix. It also updates the English and Chinese documentation of the source code referencing feature insource-build.md
to add a clarification about the sub-project configuration.Details
🤖 Generated by Copilot at 640aac1
NODE_MODULES_REGEX
constant from@modern-js/builder-shared
package inbabel.ts
andinspector.ts
files (link, link)/node_modules/
regular expression withNODE_MODULES_REGEX
constant inbabel.ts
andinspector.ts
files to avoid mismatching directories (link, link)Related Issue
Checklist
pnpm run change
.