-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(app-tools): align resolve.modules config in rspack mode #4762
fix(app-tools): align resolve.modules config in rspack mode #4762
Conversation
🦋 Changeset detectedLatest commit: 445b279 The changes in this PR will be included in the next version bump. This PR includes changesets to release 258 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4762 +/- ##
==========================================
- Coverage 57.59% 50.53% -7.07%
==========================================
Files 672 691 +19
Lines 17794 19205 +1411
Branches 3876 4432 +556
==========================================
- Hits 10249 9705 -544
- Misses 6934 8746 +1812
- Partials 611 754 +143 ☔ View full report in Codecov by Sentry. |
Summary
🤖 Generated by Copilot at 445b279
This pull request improves the webpack and rspack bundler modes for modern.js by removing unused code, adding missing configuration options, and fixing compatibility issues. It also adds a changeset file to document the patch updates for two affected packages.
Details
🤖 Generated by Copilot at 445b279
resolve.modules
configuration in therspack
mode (link)modules
property to theRspackResolve
type to allow specifying custom directories for module resolution (link)join
import from theadapterModern.ts
file (link)node_modules
directories to theresolve.modules
option in the modern mode, as it is now handled by therspack
mode (link)path
import to theadapterBasic.ts
file (link)node_modules
directories to theresolve.modules
option in the basic mode, for compatibility with modern.js v1 (link)Related Issue
web-infra-dev/rspack#4290
Checklist
pnpm run change
.