-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(plugin-testing): failed to run tests with decorators #4840
Merged
chenjiahan
merged 2 commits into
web-infra-dev:main
from
chenjiahan:legacy_decorator_testing_1024
Oct 24, 2023
Merged
fix(plugin-testing): failed to run tests with decorators #4840
chenjiahan
merged 2 commits into
web-infra-dev:main
from
chenjiahan:legacy_decorator_testing_1024
Oct 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
馃 Changeset detectedLatest commit: 235e1e3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 262 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
3 tasks
9aoy
approved these changes
Oct 24, 2023
Asuka109
pushed a commit
that referenced
this pull request
Oct 24, 2023
feat: optimize github workflow config (#4826) chore: use self host for type-checker (#4827) feat: release action trigger rsbuild update-modern workflow (#4828) fix: export reporter only in middlewares-context (#4562) feat: update rspress version (#4821) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: neverland <chenjiahan.jait@bytedance.com> chore(module-tools): add comment for resolve false in browser alias (#4818) docs: fix broken dicebear avatar api url (#4835) feat: add storybook framework (#4585) fix: modify the generated routes code, compatible with loadable and swc (#4833) chore(storybook): fix version, files and license (#4836) fix(storybook-builder): add missing files (#4837) feat: optimize generator bundle (#4838) feat(plugin-runtime): support ssr inline assets (#4735) feat: upgrade generator support handle special package (#4839) fix(module-tools): update umd global code (#4825) fix(plugin-testing): failed to run tests with decorators (#4840) fix(module-pluginnode-polyfill): no bundle globals.js (#4841)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
馃 Generated by Copilot at b67171b
This pull request adds support for the legacy decorator syntax in the
@modern-js/plugin-testing
package and the@modern-js/builder-webpack-provider
plugin. It also adds an integration test project that uses the legacy decorator syntax and verifies that it can run tests with themodern test
command. It updates the relevant files and adds a changeset to document the patch updates.Details
馃 Generated by Copilot at b67171b
pluginDecorators
option to the babel transformer and preset functions (link, link, link)testing-plugin
folder that uses the@modern-js/plugin-testing
package and the legacy decorator syntax (link, link, link, link, link, link)Related Issue
Checklist
pnpm run change
.