-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: modify the priority order of source
field and the webpack default mainFields
#4889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 083483a The changes in this PR will be included in the next version bump. This PR includes changesets to release 268 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
source
field and the webpack defa…source
field and the webpack default mainFields
chenjiahan
reviewed
Nov 1, 2023
chenjiahan
approved these changes
Nov 1, 2023
Please submit a PR to rsbuild repo too: https://github.com/web-infra-dev/rsbuild ❤️ |
OK |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
🤖 Generated by Copilot at 083483a
This pull request fixes the priority order of the
source
field in the@modern-js/builder
package. It updates thesourceBuild.ts
file and the changelog for a patch release.Details
🤖 Generated by Copilot at 083483a
source
field and the webpack default mainFields in@modern-js/builder
package (link, link)sourceField
first in themainFields
array in thebuilderPluginSourceBuild
function insourceBuild.ts
(link)resolve.conditionNames
property is not used (link)Related Issue
Checklist
pnpm run change
.