New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(storybook): fix package.json, use module.hot api #4937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
馃 Changeset detectedLatest commit: 35a4261 The changes in this PR will be included in the next version bump. This PR includes changesets to release 267 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
!canary |
1 similar comment
!canary |
targeral
reviewed
Nov 14, 2023
targeral
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix types exports in package.json
use module.hot, as rspack do not support import.meta.webpackHot in production build
馃 Generated by Copilot at 837d40d
This pull request fixes the TypeScript type resolution and the hot module replacement for the
@modern-js/storybook
and@modern-js/storybook-builder
packages. It reorders theexports
fields in thepackage.json
files and usesmodule.hot
instead ofimport.meta.hot
in the virtual module template. It also adds a changeset file to automate the release process.Details
馃 Generated by Copilot at 837d40d
@modern-js/storybook
and@modern-js/storybook-builder
packages (link)exports
subfields to puttypes
first, followed byjsnext:source
anddefault
inpackage.json
files of both packages to fix TypeScript resolution issue (link, link)import.meta.webpackHot
withmodule.hot
in virtual module template for modern entry point to enable hot module replacement withesbuild-loader
(link)Related Issue
Checklist
pnpm run change
.