-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(rspack-provider): return compiler instead of multiCompiler #4973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… targets length is 1
🦋 Changeset detectedLatest commit: f1a8e96 The changes in this PR will be included in the next version bump. This PR includes changesets to release 267 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
chenjiahan
approved these changes
Nov 20, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
create Compiler instead of MultiCompiler when target length is 1:
🤖[deprecated] Generated by Copilot at f1a8e96
This pull request enhances the
createCompiler
function in the@modern-js/builder-rspack-provider
package by adding types, simplifying logic, and fixing a bug. It also updates the changeset file for the patch release.Details
🤖[deprecated] Generated by Copilot at f1a8e96
@modern-js/builder-rspack-provider
package (link)Stats
andMultiStats
types from@rspack/core
package and use them to annotatestats
parameter ofdone
hook increateCompiler
function (link)createCompiler
function to return a singlecompiler
instance instead of amultiCompiler
instance when there is only one target inrspackConfigs
array (link)createCompiler
function by extracting a helper functionprintTime
and handling the case wherestats
object does not have achildren
property (link)Related Issue
Checklist
pnpm run change
.