Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(builder): export type of rspack config and add globalObject type #5019

Merged
merged 1 commit into from
Nov 29, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/lemon-clocks-look.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'@modern-js/builder-rspack-provider': patch
'@modern-js/builder-shared': patch
---

fix(builder): export type of rspack config and add globalObject type for rspack output
fix(builder): 导出一些 rspack config 类型同时给 rspack output 添加 globalObject 类型
6 changes: 6 additions & 0 deletions packages/builder/builder-rspack-provider/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,12 @@ export type {
// Config Types
BuilderConfig,
NormalizedConfig,
DevConfig,
OutputConfig,
ToolsConfig,
SourceConfig,
SecurityConfig,
PerformanceConfig,

// Hook Callback Types
ModifyRspackConfigFn,
Expand Down
1 change: 1 addition & 0 deletions packages/builder/builder-shared/src/types/bundlerConfig.ts
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ type RspackOutput = {
assetModuleFilename?: string;
filename?: string;
chunkFilename?: string;
globalObject?: string;
uniqueName?: string;
hashFunction?: string;
cssFilename?: string;
Expand Down