Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support split-by-module with rspack #5057

Merged
merged 2 commits into from
Dec 18, 2023

Conversation

SyMind
Copy link
Member

@SyMind SyMind commented Dec 9, 2023

Summary

Support split-by-module chunk split strategy when use rspack.

Related Links

fix #5054

Checklist

  • I have added changeset via pnpm run change.
  • I have updated the documentation.
  • I have added tests to cover my changes.

Copy link

changeset-bot bot commented Dec 9, 2023

⚠️ No Changeset found

Latest commit: b75eb88

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@SyMind
Copy link
Member Author

SyMind commented Dec 9, 2023

The module.context in rspack is currently returning undefined. We can track the status of this issue on: Issue #4953.

@SyMind
Copy link
Member Author

SyMind commented Dec 10, 2023

Fix Error: ENAMETOOLONG: name too long when use rspack. Track the status of this issue on: web-infra-dev/rspack#4964.

@SyMind SyMind marked this pull request as ready for review December 18, 2023 03:51
@SyMind
Copy link
Member Author

SyMind commented Dec 18, 2023

@chenjiahan With the release of repack v0.4.3, we can now support split-by-module when using rspack.

@chenjiahan
Copy link
Member

@SyMind Good news 😄, so can we merge this PR now?

@SyMind
Copy link
Member Author

SyMind commented Dec 18, 2023

@chenjiahan Yes, I think it's ok.

@chenjiahan chenjiahan merged commit 9877fd5 into web-infra-dev:main Dec 18, 2023
8 checks passed
@chenjiahan
Copy link
Member

Thanks for your contribution!

Can you submit a Pull Request to the Rsbuild repo too? Rsbuild is the new version of Modern.js Builder.

https://github.com/web-infra-dev/rsbuild

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: support split-by-module chunk split strategy when use rspack
2 participants