feat(uni-builder): add unified builder for Modern.js #5092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: edb3300 The changes in this PR will be included in the next version bump. This PR includes changesets to release 271 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
chenjiahan
approved these changes
Dec 14, 2023
Merged
|
|
||
| if (isProd) { | ||
| baseBabelConfig.plugins?.push([ | ||
| require.resolve('babel-plugin-transform-react-remove-prop-types'), |
There was a problem hiding this comment.
babel-plugin-transform-react-remove-prop-types 这个 plugin 默认会移除组件的 propTypes 属性。
请问在 React 配置中默认加上这个移除组件的propTypes静态属性是一个通用的做法吗？如果用户想关掉这个怎么操作呢？
There was a problem hiding this comment.
是不是排除对 node_modules 处理比较合适一点？第三方包如果用了 propTypes 做其他的事情（例如上面图里的 pick props），会造成一些预期之外的事情。
There was a problem hiding this comment.
目前需要手动通过 tools.babel 修改配置移除，后面会提供对应配置项。
在没有配置 source.include 的情况下，是只对项目 src 下的所有文件 和 项目外的 ts|tsx|jsx|mts|cts 文件编译；如果命中前面的规则但不希望转译的话，可以通过 source.exclude 排除
There was a problem hiding this comment.
目前需要手动通过 tools.babel 修改配置移除，后面会提供对应配置项。
在没有配置 source.include 的情况下，是只对项目 src 下的所有文件 和 项目外的 ts|tsx|jsx|mts|cts 文件编译；如果命中前面的规则但不希望转译的话，可以通过 source.exclude 排除
明白。不过这个配置可能会导致源码走 modernjs 的 babel 处理 react 的静态属性。很多用户不太关心这些配置，直接用的默认配置，但是默认配置会出现上面说的报错。
目前所有使用默认配置的用户都有可能在生产环境出现这个报错。团队内部是否可以讨论一下这个插件是不是默认加上。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
background: web-infra-dev/rsbuild#239 (comment)
Related Links
Checklist
pnpm run change.