New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ts-checker): remove default include glob #5342
Merged
SoonIter
merged 2 commits into
web-infra-dev:main
from
chenjiahan:ts_checker_include_0131
Jan 31, 2024
Merged
fix(ts-checker): remove default include glob #5342
SoonIter
merged 2 commits into
web-infra-dev:main
from
chenjiahan:ts_checker_include_0131
Jan 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e41181c The changes in this PR will be included in the next version bump. This PR includes changesets to release 265 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
SoonIter
approved these changes
Jan 31, 2024
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove the default include glob for TS checker, this glob will cause some errors to not be output correctly.
After removing the default include glob, TS checker now runs according to the include and exclude rules in tsconfig file.
Checklist
pnpm run change
.