-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(webpack): remove unused babel cache #926
fix(webpack): remove unused babel cache #926
Conversation
🦋 Changeset detectedLatest commit: a524ad5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 40 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## main #926 +/- ##
==========================================
- Coverage 59.75% 59.75% -0.01%
==========================================
Files 820 818 -2
Lines 35066 35012 -54
Branches 6544 6535 -9
==========================================
- Hits 20955 20920 -35
+ Misses 14075 14056 -19
Partials 36 36
Continue to review full report at Codecov.
|
dd74486
to
801d59c
Compare
* fix: remove unused babel cache * test: add test case * test: add more cases * test: add more cases * test: add alias test cases
* fix: remove unused babel cache * test: add test case * test: add more cases * test: add more cases * test: add alias test cases
* fix: remove unused babel cache * test: add test case * test: add more cases * test: add more cases * test: add alias test cases
* fix: remove unused babel cache * test: add test case * test: add more cases * test: add more cases * test: add alias test cases
PR Details
We already provide the webpack cache, there are practically no scenarios where the babel cache is hit (the webpack cache is hit first), and calculating the babel cache introduces some overhead, so we remove the babel cache related code.
This has been verified to have no impact on cold start/hot start performance.
Types of changes
Checklist