Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: port value should be string instead of int #2905

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

vikas5914
Copy link
Contributor

Summary

[doc] port value should be string instead of int

Related Links

From the same doc

port?: string;

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@CLAassistant
Copy link

CLAassistant commented Jul 12, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

netlify bot commented Jul 12, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit fe2754c
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/669142e11cb59e0008e087f7
😎 Deploy Preview https://deploy-preview-2905--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 88 (🟢 up 9 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@chenjiahan chenjiahan changed the title [doc] port value should be string instead of int docs: port value should be string instead of int Jul 12, 2024
@chenjiahan chenjiahan enabled auto-merge (squash) July 12, 2024 15:22
@chenjiahan chenjiahan merged commit 614343b into web-infra-dev:main Jul 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants