feat: new test case for context module factory before resolve hook

crates/node_binding/src/plugins/interceptor.rs

@@ -1219,10 +1219,13 @@ impl ContextModuleFactoryBeforeResolve for ContextModuleFactoryBeforeResolveTap
     match self.function.call_with_promise(js_result).await {
       Ok(js_result) => match js_result {
         napi::bindgen_prelude::Either::A(_) => Ok(BeforeResolveResult::Ignored),
-        napi::bindgen_prelude::Either::B(d) => Ok(BeforeResolveResult::Data(BeforeResolveData {
-          context: d.context,
-          request: d.request,
-        })),
+        napi::bindgen_prelude::Either::B(d) => {
+          let data = BeforeResolveData {
+            context: d.context,
+            request: d.request,
+          };
+          Ok(BeforeResolveResult::Data(Box::new(data)))
+        }
       },
       Err(err) => Err(err),
     }
@@ -1249,15 +1252,18 @@ impl ContextModuleFactoryAfterResolve for ContextModuleFactoryAfterResolveTap {
     };
     match self.function.call_with_promise(js_result).await? {
       napi::Either::A(_) => Ok(AfterResolveResult::Ignored),
-      napi::Either::B(d) => Ok(AfterResolveResult::Data(AfterResolveData {
-        resource: d.resource,
-        context: d.context,
-        request: d.request,
-        reg_exp: match d.reg_exp {
-          Some(r) => Some(RspackRegex::new(&r)?),
-          None => None,
-        },
-      })),
+      napi::Either::B(d) => {
+        let data = AfterResolveData {
+          resource: d.resource,
+          context: d.context,
+          request: d.request,
+          reg_exp: match d.reg_exp {
+            Some(r) => Some(RspackRegex::new(&r)?),
+            None => None,
+          },
+        };
+        Ok(AfterResolveResult::Data(Box::new(data)))
+      }
     }
   }
 

crates/rspack_core/src/context_module_factory.rs

@@ -15,7 +15,7 @@ use crate::{
 #[derive(Clone)]
 pub enum BeforeResolveResult {
   Ignored,
-  Data(BeforeResolveData),
+  Data(Box<BeforeResolveData>),
 }
 
 #[derive(Clone)]
@@ -37,7 +37,7 @@ pub struct BeforeResolveData {
 #[derive(Clone)]
 pub enum AfterResolveResult {
   Ignored,
-  Data(AfterResolveData),
+  Data(Box<AfterResolveData>),
 }
 
 #[derive(Clone)]
@@ -127,7 +127,7 @@ impl ContextModuleFactory {
       .plugin_driver
       .context_module_factory_hooks
       .before_resolve
-      .call(BeforeResolveResult::Data(before_resolve_data))
+      .call(BeforeResolveResult::Data(Box::new(before_resolve_data)))
       .await?
     {
       BeforeResolveResult::Ignored => Ok(Some(ModuleFactoryResult::default())),
@@ -299,7 +299,7 @@ impl ContextModuleFactory {
       .plugin_driver
       .context_module_factory_hooks
       .after_resolve
-      .call(AfterResolveResult::Data(after_resolve_data))
+      .call(AfterResolveResult::Data(Box::new(after_resolve_data)))
       .await?
     {
       AfterResolveResult::Ignored => Ok(Some(ModuleFactoryResult::default())),

packages/rspack-test-tools/tests/configCases/hooks/context-module-before-resolve/index.js

@@ -0,0 +1,15 @@
+it("should compile", async () => {
+    try {
+        ["fr.js"].map(file => {
+            require("./locale/" + file);
+        });
+    } catch (e) {
+        expect(e.message).toContain("Cannot find module './fr.js'")
+    }
+    ["zh.js"].map(file => {
+        expect(require("./locale/" + file).default).toBe("你好");
+    });
+    ["en.js"].map(file => {
+        expect(require("./locale/" + file).default).toBe("hello");
+    });
+});

packages/rspack-test-tools/tests/configCases/hooks/context-module-before-resolve/locale/en.js

@@ -0,0 +1 @@
+export default 'hello';

packages/rspack-test-tools/tests/configCases/hooks/context-module-before-resolve/locale/fr.js

@@ -0,0 +1 @@
+export default 'bonjour';

packages/rspack-test-tools/tests/configCases/hooks/context-module-before-resolve/locale/zh.js

@@ -0,0 +1 @@
+export default '你好';

packages/rspack-test-tools/tests/configCases/hooks/context-module-before-resolve/webpack.config.js

@@ -0,0 +1,26 @@
+const pluginName = "plugin";
+
+class Plugin {
+    apply(compiler) {
+        compiler.hooks.contextModuleFactory.tap(
+            pluginName,
+            contextModuleFactory => {
+                contextModuleFactory.hooks.beforeResolve.tap(pluginName, resolveData => {
+                    if (resolveData.request.includes("./locale")) {
+                        resolveData.regExp = /[/\\](en(\.js)?|zh(\.js)?)$/;
+                        return resolveData;
+                    }
+                });
+            }
+        );
+    }
+}
+/**@type {import('@rspack/cli').Configuration}*/
+module.exports = {
+    context: __dirname,
+    entry: "./index.js",
+    module: {
+        rules: []
+    },
+    plugins: [new Plugin()]
+};