Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support mini-css-extract-plugin #3210

Closed
hardfist opened this issue May 18, 2023 · 12 comments · Fixed by #5072
Closed

support mini-css-extract-plugin #3210

hardfist opened this issue May 18, 2023 · 12 comments · Fixed by #5072
Assignees
Labels
feat New feature or request rsbuild rsbuild related

Comments

@hardfist
Copy link
Contributor

What problem does this feature solve?

there are lots of difference between experiments.css and mini-css-extract-plugin which makes migrate old application hard

What does the proposed API of configuration look like?

compatible with mini-css-extract-plugin

@hardfist hardfist added feat New feature or request pending triage The issue/PR is currently untouched. labels May 18, 2023
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label May 18, 2023
@hardfist hardfist added p1-important and removed team The issue/pr is created by the member of Rspack. pending triage The issue/PR is currently untouched. labels May 18, 2023
@hardfist hardfist added this to the Planned milestone May 23, 2023
@stale
Copy link

stale bot commented Jul 22, 2023

This issue has been automatically marked as stale because it has not had recent activity. If this issue is still affecting you, please leave any comment (for example, "bump"). We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

@stale stale bot added the stale label Jul 22, 2023
@TimPetricola
Copy link

Hi there! I'm very interested in this feature (to be able to use html-inline-css-webpack-plugin). Do you know if it's still planned @hardfist ?

@stale stale bot removed the stale label Aug 4, 2023
@hardfist
Copy link
Contributor Author

hardfist commented Aug 4, 2023

yes it is still on the plan

@stale
Copy link

stale bot commented Oct 3, 2023

This issue has been automatically marked as stale because it has not had recent activity. If this issue is still affecting you, please leave any comment (for example, "bump"). We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

@stale stale bot added the stale label Oct 3, 2023
@hardfist hardfist removed this from the Planned milestone Oct 6, 2023
@stale stale bot removed the stale label Oct 6, 2023
@Narretz
Copy link

Narretz commented Oct 8, 2023

Blocked (at least) by #3519

@chenjiahan chenjiahan added the rsbuild rsbuild related label Nov 10, 2023
@chenjiahan
Copy link
Member

This issue is currently a critical blocker for Rsbuild to unify the CSS implementation.

@JSerFeng
Copy link
Collaborator

mini-css-extract-plugin needs:

  • loaderContext.importModule (Almost done)
  • create custom runtime template and runtime modules from JS (not ready yet)
  • create custom dependencies from JS (not ready yet)

We are working on it

Copy link

stale bot commented Mar 2, 2024

This issue has been automatically marked as stale because it has not had recent activity. If this issue is still affecting you, please leave any comment (for example, "bump"). We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

@stale stale bot added the stale label Mar 2, 2024
@xc2
Copy link
Collaborator

xc2 commented Mar 2, 2024

bump

@OskarLebuda
Copy link

@JSerFeng @hardfist any updates?
Without this feature we cannot migrate to rspack :(

@xc2
Copy link
Collaborator

xc2 commented Mar 27, 2024

@JSerFeng @hardfist any updates? Without this feature we cannot migrate to rspack :(

hi there, per discord thread, it's being blocked by newTreeshaking implementation and might land in next two weeks.

ref: https://discord.com/channels/977448667919286283/1221151979871666208/1221477773902872606

@stale stale bot removed the stale label Mar 27, 2024
@OskarLebuda
Copy link

@JSerFeng @hardfist any updates? Without this feature we cannot migrate to rspack :(

hi there, per discord thread, it's being blocked by newTreeshaking implementation and might land in next two weeks.

ref: https://discord.com/channels/977448667919286283/1221151979871666208/1221477773902872606

I see the threat thanks 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request rsbuild rsbuild related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants