Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

builtin provider should use ProviderDependency to implment this #3544

Closed
underfin opened this issue Jun 14, 2023 · 3 comments
Closed

builtin provider should use ProviderDependency to implment this #3544

underfin opened this issue Jun 14, 2023 · 3 comments
Labels
bug Something isn't working stale team The issue/pr is created by the member of Rspack.

Comments

@underfin
Copy link
Collaborator

underfin commented Jun 14, 2023 •
edited
Loading

System Info

Details

  • Current implement

Using require('xx') to do it, but it isn't correct for esm module, please see #3203

Reproduce link

No response

Reproduce Steps
@underfin underfin added bug Something isn't working pending triage The issue/PR is currently untouched. labels Jun 14, 2023
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Jun 14, 2023
@underfin underfin mentioned this issue Jul 10, 2023
Merged
@underfin underfin mentioned this issue Jul 19, 2023
Closed
@stale
Copy link

stale bot commented Aug 13, 2023

This issue has been automatically marked as stale because it has not had recent activity. If this issue is still affecting you, please leave any comment (for example, "bump"). We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

@stale stale bot added the stale label Aug 13, 2023
This was referenced Oct 24, 2023
Merged
Merged
Merged
Merged
@github-actions github-actions bot mentioned this issue Nov 7, 2023
Merged
2 tasks
@jerrykingxyz jerrykingxyz removed the pending triage The issue/PR is currently untouched. label Nov 13, 2023
This was referenced Nov 20, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
This was referenced Nov 29, 2023
Merged
Merged
Merged
Merged
Closed
This was referenced Dec 7, 2023
Merged
Merged
This was referenced May 15, 2024
Merged
Merged
Merged
Merged
This was referenced May 27, 2024
Merged
Merged
Merged
This was referenced Jun 7, 2024
Merged
Merged
Merged
This was referenced Jun 21, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Jul 3, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Jul 11, 2024
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working stale team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: implement builtins.provide by provide dependency web-infra-dev/rspack
3 participants
@hardfist @jerrykingxyz @underfin