-
-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: should not always rely on Result
#4880
Merged
h-a-n-a
merged 5 commits into
main
from
12-04-refactor_unexpected_should_not_always_rely_on
Dec 11, 2023
Merged
refactor: should not always rely on Result
#4880
h-a-n-a
merged 5 commits into
main
from
12-04-refactor_unexpected_should_not_always_rely_on
Dec 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
2 tasks
6b52494
to
11bdaf9
Compare
8be73a9
to
97c1c78
Compare
Test Compatibility Diff
Unpassed tests
|
11bdaf9
to
4c359da
Compare
97c1c78
to
93a90e2
Compare
93a90e2
to
1aa1c32
Compare
3406e7f
to
4c359da
Compare
2 tasks
3406e7f
to
371fc68
Compare
1aa1c32
to
ef58d0a
Compare
371fc68
to
7188841
Compare
ef58d0a
to
30d6959
Compare
7188841
to
61772dc
Compare
30d6959
to
253cffb
Compare
61772dc
to
e6d3be0
Compare
316d42e
to
741562a
Compare
f674500
to
392878d
Compare
741562a
to
a96f430
Compare
392878d
to
8253343
Compare
a96f430
to
5a0b6fa
Compare
8253343
to
f9ad11f
Compare
5a0b6fa
to
776d067
Compare
f9ad11f
to
d8388ff
Compare
776d067
to
799401b
Compare
ef9a248
to
31061cf
Compare
0bb3bf9
to
62886d7
Compare
31061cf
to
361c3fe
Compare
7109327
to
c55a30c
Compare
361c3fe
to
4b3fffe
Compare
h-a-n-a
commented
Dec 8, 2023
h-a-n-a
commented
Dec 8, 2023
ahabhgk
approved these changes
Dec 11, 2023
This was referenced Dec 18, 2023
ahabhgk
pushed a commit
that referenced
this pull request
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adjust some of expectations with the philosophy of #4848:
Test Plan
as-is.
Require Documentation?