Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: loader api add dependency #2121

Merged
merged 2 commits into from
Mar 10, 2023
Merged

feat: loader api add dependency #2121

merged 2 commits into from
Mar 10, 2023

Conversation

MBearo
Copy link
Contributor

@MBearo MBearo commented Mar 10, 2023 •
edited

Summary

Related issue (if exists)

Types of changes

  • Docs change / Dependency upgrade
  • Bug fix
  • New feature / Improvement
  • Refactoring
  • Breaking change

Checklist

  • I have added changeset via pnpm run changeset.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Mar 10, 2023 •
edited

🦋 Changeset detected

Latest commit: d0d1d0a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@rspack/core Patch
@rspack/cli Patch
@rspack/dev-middleware Patch
@rspack/dev-server Patch
@rspack/plugin-html Patch
benchmarkcase-rspack-react-refresh Patch
@rspack/postcss-loader Patch
@rspack/dev-client Patch
@rspack/plugin-minify Patch
@rspack/plugin-node-polyfill Patch
@rspack/binding-darwin-arm64 Patch
@rspack/binding-darwin-x64 Patch
@rspack/binding-linux-x64-gnu Patch
@rspack/binding-win32-x64-msvc Patch
@rspack/binding Patch
@rspack/fs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Mar 10, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@h-a-n-a
Copy link
Collaborator

h-a-n-a commented Mar 10, 2023 •
edited

Looks good. Would you sign the CLA and add a changeset to that change?
You may directly copy the PR title as the message and add with a patch change.

@h-a-n-a h-a-n-a changed the title fix: loader api add dependency #2120 feat: loader api add dependency Mar 10, 2023
ahabhgk
ahabhgk previously approved these changes Mar 10, 2023
View reviewed changes
@IWANABETHATGUY IWANABETHATGUY enabled auto-merge (squash) March 10, 2023 05:50
@h-a-n-a h-a-n-a disabled auto-merge March 10, 2023 06:04
@ahabhgk ahabhgk linked an issue Mar 10, 2023 that may be closed by this pull request
[Bug Report]: ctx.dependency is not a function #2120
Closed
IWANABETHATGUY
IWANABETHATGUY previously approved these changes Mar 10, 2023
View reviewed changes
@IWANABETHATGUY IWANABETHATGUY enabled auto-merge (squash) March 10, 2023 07:05
@h-a-n-a h-a-n-a dismissed stale reviews from IWANABETHATGUY and ahabhgk via a1607a3 March 10, 2023 08:12
@h-a-n-a h-a-n-a disabled auto-merge March 10, 2023 08:16
@h-a-n-a h-a-n-a merged commit 706207a into web-infra-dev:main Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-a-n-a h-a-n-a h-a-n-a approved these changes

@ahabhgk ahabhgk ahabhgk approved these changes

@IWANABETHATGUY IWANABETHATGUY IWANABETHATGUY left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug Report]: ctx.dependency is not a function
5 participants
@MBearo @CLAassistant @h-a-n-a @IWANABETHATGUY @ahabhgk