Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugin-wasm): add async-wasm support #2229

Merged
merged 9 commits into from
Mar 26, 2023
Merged

Conversation

tuchg
Copy link
Contributor

@tuchg tuchg commented Mar 13, 2023

Summary

Async wasm support has been added, along with partial support for loading wasm using "fetch".

However, sync WebAssembly support has not yet been added.

The wasm-parser crate is used to parse WebAssembly ast, and the currently supported webpack-related tests have been successfully ported.

Related issue (if exists)

Types of changes

  • Docs change / Dependency upgrade
  • Bug fix
  • New feature / Improvement
  • Refactoring
  • Breaking change

Checklist

  • I have added changeset via pnpm run changeset.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Mar 13, 2023

🦋 Changeset detected

Latest commit: 1c6896d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@rspack/binding Patch
@rspack/core Patch
@rspack/cli Patch
@rspack/postcss-loader Patch
@rspack/dev-middleware Patch
@rspack/dev-server Patch
@rspack/plugin-html Patch
benchmarkcase-rspack-react-refresh Patch
@rspack/dev-client Patch
@rspack/plugin-minify Patch
@rspack/plugin-node-polyfill Patch
@rspack/binding-darwin-arm64 Patch
@rspack/binding-darwin-x64 Patch
@rspack/binding-linux-x64-gnu Patch
@rspack/binding-win32-x64-msvc Patch
@rspack/fs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hardfist
Copy link
Contributor

I'm shocked!

@zoolsher
Copy link
Contributor

You rock!

@hardfist hardfist requested a review from ahabhgk March 14, 2023 03:19
@ahabhgk
Copy link
Collaborator

ahabhgk commented Mar 14, 2023

Feel free to ping me once this is ready to review @tuchg

@tuchg tuchg marked this pull request as ready for review March 18, 2023 11:17
@tuchg
Copy link
Contributor Author

tuchg commented Mar 18, 2023

@ahabhgk hi, it's done.

@tuchg tuchg mentioned this pull request Mar 25, 2023
7 tasks
@tuchg tuchg requested a review from ahabhgk March 26, 2023 04:27
Copy link
Collaborator

@ahabhgk ahabhgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ahabhgk ahabhgk merged commit b323220 into web-infra-dev:main Mar 26, 2023
@ahabhgk ahabhgk linked an issue Mar 30, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Native WebAssembly Support
4 participants