Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(testing): resolve context for fixtures controlled by test.config.js #2234

Merged
merged 2 commits into from
Mar 14, 2023

Conversation

tuchg
Copy link
Contributor

@tuchg tuchg commented Mar 14, 2023

Summary

Resolved a serious issue with cargo test fixtures controlled by test.config.js config file was not able to retrieve correctly context information during execution, leading to test failures.
This optimization improves the contributor maintenance experience.

image

Related issue (if exists)

Types of changes

  • Docs change / Dependency upgrade
  • Bug fix
  • New feature / Improvement
  • Refactoring
  • Breaking change

Checklist

  • I have added changeset via pnpm run changeset.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Mar 14, 2023

⚠️ No Changeset found

Latest commit: 8171ea8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

crates/rspack_testing/src/eval_raw.rs Outdated Show resolved Hide resolved
Co-authored-by: Gengkun <ahabhgk@gmail.com>
@tuchg tuchg requested a review from ahabhgk March 14, 2023 06:26
@ahabhgk ahabhgk merged commit f3cf1ff into web-infra-dev:main Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants