Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: try rs test run in single thread #2235

Merged
merged 3 commits into from
Mar 14, 2023
Merged

fix: try rs test run in single thread #2235

merged 3 commits into from
Mar 14, 2023

Conversation

IWANABETHATGUY
Copy link
Contributor

@IWANABETHATGUY IWANABETHATGUY commented Mar 14, 2023

Summary

  1. Try to fix random test fail and retry success
    here is the time cost between test-threads=1, and test-threads=${defualt-value}
  2. Notice that our rspack is still running in multi-thread, this change only makes the testing tasks run in single thread.

default

image

test-threds=1

image

Related issue (if exists)

Types of changes

  • Docs change / Dependency upgrade
  • Bug fix
  • New feature / Improvement
  • Refactoring
  • Breaking change

Checklist

  • I have added changeset via pnpm run changeset.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Mar 14, 2023

⚠️ No Changeset found

Latest commit: 1388a87

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Mar 14, 2023
@IWANABETHATGUY IWANABETHATGUY changed the title Fix/test thread fix: test run in single thread Mar 14, 2023
@IWANABETHATGUY IWANABETHATGUY changed the title fix: test run in single thread fix: try rs test run in single thread Mar 14, 2023
@IWANABETHATGUY IWANABETHATGUY merged commit 2ab3228 into main Mar 14, 2023
@IWANABETHATGUY IWANABETHATGUY deleted the fix/test-thread branch March 14, 2023 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants