Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(html): builtins.html minify not work #2306

Merged
merged 1 commit into from
Mar 17, 2023
Merged

fix(html): builtins.html minify not work #2306

merged 1 commit into from
Mar 17, 2023

Conversation

jerrykingxyz
Copy link
Collaborator

Summary

Related issue (if exists)

Types of changes

  • Docs change / Dependency upgrade
  • Bug fix
  • New feature / Improvement
  • Refactoring
  • Breaking change

Checklist

  • I have added changeset via pnpm run changeset.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Mar 16, 2023

🦋 Changeset detected

Latest commit: b1fe5f1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@rspack/binding Patch
@rspack/postcss-loader Patch
@rspack/core Patch
@rspack/cli Patch
@rspack/dev-middleware Patch
@rspack/dev-server Patch
@rspack/plugin-html Patch
benchmarkcase-rspack-react-refresh Patch
@rspack/dev-client Patch
@rspack/plugin-minify Patch
@rspack/plugin-node-polyfill Patch
@rspack/binding-darwin-arm64 Patch
@rspack/binding-darwin-x64 Patch
@rspack/binding-linux-x64-gnu Patch
@rspack/binding-win32-x64-msvc Patch
@rspack/fs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Mar 16, 2023
@jerrykingxyz jerrykingxyz linked an issue Mar 16, 2023 that may be closed by this pull request
IWANABETHATGUY
IWANABETHATGUY previously approved these changes Mar 16, 2023
h-a-n-a
h-a-n-a previously approved these changes Mar 16, 2023
ahabhgk
ahabhgk previously approved these changes Mar 16, 2023
@jerrykingxyz jerrykingxyz merged commit a54179d into main Mar 17, 2023
@jerrykingxyz jerrykingxyz deleted the jerry/html branch March 17, 2023 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report]: can not use minify in builtins.html
5 participants