Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: cache pnpm in check-rs #2308

Merged
merged 1 commit into from
Mar 17, 2023
Merged

ci: cache pnpm in check-rs #2308

merged 1 commit into from
Mar 17, 2023

Conversation

Boshen
Copy link
Contributor

@Boshen Boshen commented Mar 16, 2023

Summary

Related issue (if exists)

Types of changes

  • Docs change / Dependency upgrade
  • Bug fix
  • New feature / Improvement
  • Refactoring
  • Breaking change

Checklist

  • I have added changeset via pnpm run changeset.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Mar 16, 2023

⚠️ No Changeset found

Latest commit: 5a511c3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Mar 16, 2023
@h-a-n-a h-a-n-a merged commit 6aefac8 into main Mar 17, 2023
@h-a-n-a h-a-n-a deleted the cache-pnpm branch March 17, 2023 05:41
Boshen added a commit that referenced this pull request Mar 17, 2023
@Boshen
Revert "ci: cache pnpm in check-rs (#2308)"
df0e6d0 
This reverts commit 6aefac8.
Boshen added a commit that referenced this pull request Mar 17, 2023
@Boshen
Revert "ci: cache pnpm in check-rs (#2308)" (#2326)
3cf6b2e 
This reverts commit 6aefac8.
h-a-n-a added a commit that referenced this pull request Mar 17, 2023
@h-a-n-a
Revert "ci: cache pnpm in check-rs (#2308)"
d0b7416 
This reverts commit 6aefac8.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-a-n-a h-a-n-a h-a-n-a approved these changes

@IWANABETHATGUY IWANABETHATGUY Awaiting requested review from IWANABETHATGUY

Assignees
No one assigned
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Boshen @h-a-n-a