Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support new URL("./foo", import.meta.url) #2340

Merged
merged 1 commit into from
Mar 23, 2023
Merged

feat: Support new URL("./foo", import.meta.url) #2340

merged 1 commit into from
Mar 23, 2023

Conversation

magic-akari
Copy link
Contributor

Summary

Support importing dependencies with new URL (url, import.meta.url) like Vite.
It is a modern method for declaring dependencies, particularly when it comes to static resources such as PNG and SVG files.

Related issue (if exists)

Types of changes

  • Docs change / Dependency upgrade
  • Bug fix
  • New feature / Improvement
  • Refactoring
  • Breaking change

Checklist

  • I have added changeset via pnpm run changeset.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Mar 18, 2023

🦋 Changeset detected

Latest commit: 6fcadbc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@rspack/core Patch
@rspack/cli Patch
@rspack/dev-middleware Patch
@rspack/dev-server Patch
@rspack/plugin-html Patch
benchmarkcase-rspack-react-refresh Patch
@rspack/postcss-loader Patch
@rspack/dev-client Patch
@rspack/plugin-minify Patch
@rspack/plugin-node-polyfill Patch
@rspack/binding-darwin-arm64 Patch
@rspack/binding-darwin-x64 Patch
@rspack/binding-linux-x64-gnu Patch
@rspack/binding-win32-x64-msvc Patch
@rspack/binding Patch
@rspack/fs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Mar 18, 2023

CLA assistant check
All committers have signed the CLA.

@magic-akari magic-akari marked this pull request as ready for review March 18, 2023 11:20
@magic-akari magic-akari marked this pull request as draft March 18, 2023 11:43
@magic-akari magic-akari marked this pull request as ready for review March 18, 2023 13:40
@ahabhgk ahabhgk requested a review from h-a-n-a March 23, 2023 06:14
@jerrykingxyz jerrykingxyz merged commit 1aadf05 into web-infra-dev:main Mar 23, 2023
@beaucollins beaucollins mentioned this pull request Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants