Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): mode default config by process.env.NODE_ENV #2343

Merged
merged 1 commit into from
Mar 23, 2023
Merged

fix(cli): mode default config by process.env.NODE_ENV #2343

merged 1 commit into from
Mar 23, 2023

Conversation

SoonIter
Copy link
Member

Summary

  • auto set "mode" by NODE_ENV, remove the hardcoded config
  • extract "buildConfig" method

Related issue (if exists)

closes #2280

Types of changes

  • Docs change / Dependency upgrade
  • Bug fix
  • New feature / Improvement
  • Refactoring
  • Breaking change

Checklist

  • I have added changeset via pnpm run changeset.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Mar 19, 2023 •
edited

🦋 Changeset detected

Latest commit: 9db25ff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@rspack/cli Patch
benchmarkcase-rspack-react-refresh Patch
@rspack/postcss-loader Patch
@rspack/dev-client Patch
@rspack/dev-middleware Patch
@rspack/dev-server Patch
@rspack/plugin-html Patch
@rspack/plugin-minify Patch
@rspack/plugin-node-polyfill Patch
@rspack/core Patch
@rspack/binding-darwin-arm64 Patch
@rspack/binding-darwin-x64 Patch
@rspack/binding-linux-x64-gnu Patch
@rspack/binding-win32-x64-msvc Patch
@rspack/binding Patch
@rspack/fs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@SoonIter SoonIter force-pushed the remove-rspack-env branch 2 times, most recently from 8ba08f7 to 59bfb5a Compare March 19, 2023 08:58
@SoonIter
Copy link
Member Author

@h-a-n-a cc

h-a-n-a
h-a-n-a previously approved these changes Mar 22, 2023
View reviewed changes
@h-a-n-a h-a-n-a changed the title chore(cli): mode default config by process.env.NODE_ENV fix(cli): mode default config by process.env.NODE_ENV Mar 22, 2023
@jerrykingxyz
Copy link
Collaborator

LGTM, I will merge it after resolved conflicts

@jerrykingxyz jerrykingxyz merged commit d80430c into web-infra-dev:main Mar 23, 2023
This was referenced Mar 28, 2023
Closed
Closed
Closed
Merged
hardfist added a commit that referenced this pull request Mar 29, 2023
@hardfist
Revert "fix(cli): mode default config by process.env.NODE_ENV (#2343)"
277debf 
This reverts commit d80430c.
hardfist added a commit that referenced this pull request Mar 29, 2023
@hardfist
Revert "fix(cli): mode default config by process.env.NODE_ENV (#2343)" (
2892ab1 
#2528)

This reverts commit d80430c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pranav-yadav Pranav-yadav Pranav-yadav left review comments

@jerrykingxyz jerrykingxyz jerrykingxyz approved these changes

@h-a-n-a h-a-n-a h-a-n-a left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

File watch mode.
4 participants
@SoonIter @jerrykingxyz @h-a-n-a @Pranav-yadav