Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(rspack_util): add test cases #2346

Merged
merged 8 commits into from
Mar 21, 2023
Merged

Conversation

ycjcl868
Copy link
Contributor

Summary

Related issue (if exists)

Types of changes

  • Docs change / Dependency upgrade
  • Bug fix
  • New feature / Improvement
  • Refactoring
  • Breaking change

Checklist

  • I have added changeset via pnpm run changeset.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Mar 19, 2023

⚠️ No Changeset found

Latest commit: 9316e6f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ycjcl868
Copy link
Contributor Author

According to the previous test cases, will they be added later?

https://github.com/webpack/webpack/blob/4b4ca3bb53f36a5b8fc6bc1bd976ed7af161bd80/test/identifier.unittest.js#L8

image

@hardfist hardfist added this to the build_infra & test_infra milestone Mar 20, 2023
@hardfist
Copy link
Contributor

thank you, adding rust unittest is very helpful

@jerrykingxyz jerrykingxyz merged commit 3afa541 into web-infra-dev:main Mar 21, 2023
@ycjcl868 ycjcl868 deleted the test/util branch March 21, 2023 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants