Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose description data to resolve_data #2348

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

bvanjoi
Copy link
Collaborator

@bvanjoi bvanjoi commented Mar 19, 2023

This PR brings the following changes:

  1. more friendly error tips when tsconfig not founded.
  2. expose description data(package.json) to resourceData. close [Feature Request]: nodejs should return resourceData.data.descriptionFileData #2298

@changeset-bot
Copy link

changeset-bot bot commented Mar 19, 2023

⚠️ No Changeset found

Latest commit: 4ab9291

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Mar 19, 2023
@bvanjoi bvanjoi force-pushed the expose-description-data-to-resource branch from 7c3f837 to 4ab9291 Compare March 19, 2023 14:37
@bvanjoi
Copy link
Collaborator Author

bvanjoi commented Mar 19, 2023

!bench

@github-actions
Copy link
Contributor

Benchmark Results

group                                                 baseline                               pr
-----                                                 --------                               --
criterion_benchmark/ten_copy_of_threejs               1.00       2.4±0.11s        ? ?/sec    1.02       2.4±0.10s        ? ?/sec
high_cost_benchmark/ten_copy_of_threejs_production    1.01      10.0±0.33s        ? ?/sec    1.00       9.9±0.27s        ? ?/sec

@bvanjoi bvanjoi merged commit 84087de into main Mar 20, 2023
@bvanjoi bvanjoi deleted the expose-description-data-to-resource branch March 20, 2023 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: nodejs should return resourceData.data.descriptionFileData
3 participants