Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add CODEOWNERS #2480

Merged
merged 1 commit into from
Mar 31, 2023
Merged

chore: add CODEOWNERS #2480

merged 1 commit into from
Mar 31, 2023

Conversation

Boshen
Copy link
Contributor

@Boshen Boshen commented Mar 27, 2023

Summary

Setup CODEOWNERS for easier reviewer assignments.
@hardfist Can you assign these to the correct person, you can push to this branch.

Related issue (if exists)

Types of changes

  • Docs change / Dependency upgrade
  • Bug fix
  • New feature / Improvement
  • Refactoring
  • Breaking change

Checklist

  • I have added changeset via pnpm run changeset.
  • I have added tests to cover my changes.

@Boshen Boshen requested a review from hardfist March 27, 2023 09:04
@changeset-bot
Copy link

changeset-bot bot commented Mar 27, 2023

⚠️ No Changeset found

Latest commit: 1dd0fc0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Mar 27, 2023
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
@IWANABETHATGUY
Copy link
Contributor

@web-infra-dev/rspack

.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
@h-a-n-a
Copy link
Collaborator

h-a-n-a commented Mar 29, 2023

@web-infra-dev/rspack

@Boshen Boshen marked this pull request as ready for review March 29, 2023 06:14
@Boshen
Copy link
Contributor Author

Boshen commented Mar 29, 2023

@web-infra-dev/rspack Can you double check and assign the node packages as well?

@hyf0 hyf0 linked an issue Mar 29, 2023 that may be closed by this pull request
@Boshen
Copy link
Contributor Author

Boshen commented Mar 30, 2023

@hardfist can you double check?

.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
@Boshen Boshen added this pull request to the merge queue Mar 31, 2023
Merged via the queue into main with commit e40bda7 Mar 31, 2023
@Boshen Boshen deleted the codeowners branch March 31, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

codeowner
6 participants