Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix hmr not working #2543

Merged
merged 1 commit into from
Mar 29, 2023
Merged

fix: fix hmr not working #2543

merged 1 commit into from
Mar 29, 2023

Conversation

hardfist
Copy link
Contributor

Summary

js hmr is broken due to css hmr crash which cause js hmr logic is not executed

Related issue (if exists)

Types of changes

  • Docs change / Dependency upgrade
  • Bug fix
  • New feature / Improvement
  • Refactoring
  • Breaking change

Checklist

  • I have added changeset via pnpm run changeset.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Mar 29, 2023

⚠️ No Changeset found

Latest commit: f1d798b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Mar 29, 2023
This was linked to issues Mar 29, 2023
[Bug Report]: HMR is broken on the FS project for rspack@0.1.3 #2527
Closed
[Bug Report]: Runtime css_loading_with_hmr.js contains invalid code, a variable callled error is accessed but not declared #2539
Closed
@hardfist hardfist merged commit 21feb85 into main Mar 29, 2023
@hardfist hardfist deleted the fix-hmr branch March 29, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-a-n-a h-a-n-a h-a-n-a approved these changes

@hyf0 hyf0 hyf0 approved these changes

Assignees
No one assigned
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
3 participants
@hardfist @h-a-n-a @hyf0