Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rspack-cli): emit warning if the using nodejs version is not recommended #2575

Merged
merged 4 commits into from
Apr 1, 2023
Merged

feat(rspack-cli): emit warning if the using nodejs version is not recommended #2575

merged 4 commits into from
Apr 1, 2023

Conversation

dhruvkelawala
Copy link
Contributor

@dhruvkelawala dhruvkelawala commented Mar 31, 2023 •
edited

Summary

Rspack doesn’t support nodejs lower than 12(include 12).

To provide a better experience, Rspack should validate the version of nodejs where Rspack is running.

Related issue (if exists)

#2486

Types of changes

  • Docs change / Dependency upgrade
  • Bug fix
  • New feature / Improvement
  • Refactoring
  • Breaking change

Checklist

  • I have added changeset via pnpm run changeset.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Mar 31, 2023 •
edited

⚠️ No Changeset found

Latest commit: ed868c4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dhruvkelawala dhruvkelawala changed the title feat: validate nodejs version chore: validate nodejs version Mar 31, 2023
@hyf0 hyf0 linked an issue Apr 1, 2023 that may be closed by this pull request
[Feature Request]: Rspack should validate the version of nodejs #2486
Closed
@hyf0 hyf0 self-requested a review April 1, 2023 13:53
@hyf0 hyf0 self-assigned this Apr 1, 2023
hyf0
hyf0 approved these changes Apr 1, 2023
View reviewed changes
Copy link
Collaborator

@hyf0 hyf0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@hyf0 hyf0 changed the title chore: validate nodejs version feat: emit warning if the using nodejs version is not recommended Apr 1, 2023
@hyf0 hyf0 changed the title feat: emit warning if the using nodejs version is not recommended feat(rspack-cli): emit warning if the using nodejs version is not recommended Apr 1, 2023
@hyf0 hyf0 added this pull request to the merge queue Apr 1, 2023
Merged via the queue into web-infra-dev:main with commit a5170ad Apr 1, 2023
4 checks passed
@hyf0 hyf0 mentioned this pull request Apr 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyf0 hyf0 hyf0 approved these changes

Assignees

@hyf0 hyf0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Rspack should validate the version of nodejs
2 participants
@dhruvkelawala @hyf0