Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dev-client): use webpack-dev-server/client directly #2576

Merged
merged 1 commit into from
Apr 3, 2023
Merged

fix(dev-client): use webpack-dev-server/client directly #2576

merged 1 commit into from
Apr 3, 2023

Conversation

bvanjoi
Copy link
Collaborator

@bvanjoi bvanjoi commented Apr 1, 2023 •
edited

This PR brings two changes:

  1. Thanks to the implementation of provide, we can now use webpack-dev-server/client directly
  2. fix pnpm version to 7.25.0

@bvanjoi bvanjoi requested a review from hardfist as a code owner April 1, 2023 06:40
@changeset-bot
Copy link

changeset-bot bot commented Apr 1, 2023 •
edited

🦋 Changeset detected

Latest commit: 5fc2941

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@rspack/dev-client Patch
@rspack/dev-server Patch
@rspack/core Patch
webpack-test Patch
@rspack/playground Patch
@rspack/cli Patch
@rspack/dev-middleware Patch
@rspack/plugin-html Patch
benchmarkcase-rspack-react-refresh Patch
@rspack/postcss-loader Patch
@rspack/plugin-minify Patch
@rspack/plugin-node-polyfill Patch
@rspack/binding-darwin-arm64 Patch
@rspack/binding-darwin-x64 Patch
@rspack/binding-linux-x64-gnu Patch
@rspack/binding-win32-x64-msvc Patch
@rspack/binding Patch
@rspack/fs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Apr 1, 2023
@bvanjoi bvanjoi force-pushed the remove-custom-dev-client branch 2 times, most recently from fc4ebb8 to 8732dc4 Compare April 1, 2023 07:20
@bvanjoi bvanjoi changed the title refactor(dev-client): use webpack-dev-server directly refactor(dev-client): use webpack-dev-server/client directly Apr 1, 2023
@bvanjoi bvanjoi enabled auto-merge April 1, 2023 08:07
underfin
underfin previously approved these changes Apr 3, 2023
View reviewed changes
ahabhgk
ahabhgk previously approved these changes Apr 3, 2023
View reviewed changes
@bvanjoi bvanjoi dismissed stale reviews from ahabhgk and underfin via de21940 April 3, 2023 13:48
@bvanjoi bvanjoi force-pushed the remove-custom-dev-client branch 3 times, most recently from d5b4de6 to 0865b53 Compare April 3, 2023 13:54
@bvanjoi bvanjoi changed the title refactor(dev-client): use webpack-dev-server/client directly fix(dev-client): use webpack-dev-server/client directly Apr 3, 2023
@bvanjoi bvanjoi added this pull request to the merge queue Apr 3, 2023
Merged via the queue into main with commit 3607f25 Apr 3, 2023
5 of 6 checks passed
@bvanjoi bvanjoi deleted the remove-custom-dev-client branch April 3, 2023 14:34
@github-actions github-actions bot mentioned this pull request Apr 4, 2023
Merged
@hardfist hardfist mentioned this pull request Apr 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardfist hardfist hardfist approved these changes

@underfin underfin underfin left review comments

@ahabhgk ahabhgk ahabhgk left review comments

Assignees
No one assigned
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bvanjoi @hardfist @underfin @ahabhgk