fix(hmr): improve detecting of ReactRefreshBoundary and Return value of React.createContext is not considered as React component
#2587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c718f0f The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
team
ahabhgk
previously approved these changes
Apr 3, 2023
underfin
force-pushed
the
fix-react-refresh
branch
from
1ca21c3
to
1b8227e
Compare
|
Could you link the issues this PR fixed? |
hyf0
changed the title
React.createContext is not considered as React component
hyf0
previously approved these changes
Apr 3, 2023
hyf0
previously approved these changes
Apr 3, 2023
hyf0
previously approved these changes
Apr 3, 2023
hardfist
previously approved these changes
Apr 3, 2023
bvanjoi
previously approved these changes
Apr 3, 2023
underfin
force-pushed
the
fix-react-refresh
branch
from
75b3fe8
to
68d5006
Compare
h-a-n-a
reviewed
Apr 4, 2023
h-a-n-a
reviewed
Apr 4, 2023
h-a-n-a
approved these changes
Apr 4, 2023
ahabhgk
approved these changes
Apr 4, 2023
hardfist
approved these changes
Apr 4, 2023
hardfist
pushed a commit
that referenced
this pull request
Apr 4, 2023
* feat(html): support templateContent in `builtins.html` (#2589) * feat(html): support templateContent in `builtins.html` * fix: ci * fix(hmr): improve detecting of ReactRefreshBoundary and Return value of `React.createContext` is not considered as React component (#2587) * fix: react refresh with context * chore: use @pmmmwh/react-refresh-webpack-plugin runtime * chore: add comment * chore: fix promise * ci: release pre check (#2606) * chore: 🤖 release pre check * chore: 🤖 cacnel release workflow * fix: draw progress bar to stdout instead of stderr, close #1434 (#2599) * fix: bump nodejs-resolver to fix path issue with chinese characaters (#2506) * refactor: upgrade nodejs_resolver * feat(resolve): support fullySpecified * Release v0.1.6 --------- Co-authored-by: jinrui <jerrykingxyz@gmail.com> Co-authored-by: underfin <likui6666666@gmail.com> Co-authored-by: IWANABETHATGUY <iwanabethatguy@qq.com> Co-authored-by: zjk <jingkai.zhao@foxmail.com> Co-authored-by: bohan <bohan-zhang@foxmail.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Thanks for @hyf0 to resolve the issue with me.
react-refresh-webpack-plugin,it should detect component at runtime, it can fix react context hmr issue__webpack_module__.idRelated issue (if exists)
close #2266
Types of changes
Checklist
pnpm run changeset.