Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: several style change for more concise code #2655

Merged
merged 4 commits into from
Apr 10, 2023
Merged

chore: several style change for more concise code #2655

merged 4 commits into from
Apr 10, 2023

Conversation

HerringtonDarkholme
Copy link
Collaborator

@HerringtonDarkholme HerringtonDarkholme commented Apr 7, 2023 •
edited

Summary

Pure refactoring. I also added some comments and used meaning variable name to improve readability.

Related issue (if exists)

N/A

Types of changes

  • Docs change / Dependency upgrade
  • Bug fix
  • New feature / Improvement
  • Refactoring
  • Breaking change

Checklist

  • I have added changeset via pnpm run changeset.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Apr 7, 2023 •
edited

⚠️ No Changeset found

Latest commit: 85f7baf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

IWANABETHATGUY
IWANABETHATGUY approved these changes Apr 10, 2023
View reviewed changes
Copy link
Contributor

@IWANABETHATGUY IWANABETHATGUY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Apr 10, 2023
Merged via the queue into web-infra-dev:main with commit c79bfe1 Apr 10, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IWANABETHATGUY IWANABETHATGUY IWANABETHATGUY approved these changes

@h-a-n-a h-a-n-a Awaiting requested review from h-a-n-a

@hyf0 hyf0 Awaiting requested review from hyf0

Assignees

@IWANABETHATGUY IWANABETHATGUY

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@HerringtonDarkholme @IWANABETHATGUY @hyf0