Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix compile time is NaN in watch #2656

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

HerringtonDarkholme
Copy link
Collaborator

Summary

fix #2654, we should store last startTime before resetting

Related issue (if exists)

#2654

Types of changes

  • Docs change / Dependency upgrade
  • Bug fix
  • New feature / Improvement
  • Refactoring
  • Breaking change

Checklist

  • I have added changeset via pnpm run changeset.
  • I have added tests to cover my changes.

fix web-infra-dev#2654, we should store last startTime before resetting
@changeset-bot
Copy link

changeset-bot bot commented Apr 7, 2023

⚠️ No Changeset found

Latest commit: bc9dacd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Collaborator

@ahabhgk ahabhgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ahabhgk ahabhgk added this pull request to the merge queue Apr 7, 2023
Merged via the queue into web-infra-dev:main with commit 4c12ed7 Apr 7, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report]: The compile time printed is NaN
2 participants