Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: stats module reason type and userRequest #2671

Merged
merged 13 commits into from
Apr 9, 2023

Conversation

faga295
Copy link
Contributor

@faga295 faga295 commented Apr 8, 2023

Summary

This PR includes the type and user_request fields, which can be obtained directly through dependency. The remaining fields, such as loc and resolvedModuleIdentifier, any of which I think can be used as a separate PR.

Related issue (if exists)

#2593

Types of changes

  • Docs change / Dependency upgrade
  • Bug fix
  • New feature / Improvement
  • Refactoring
  • Breaking change

Checklist

  • I have added changeset via pnpm run changeset.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Apr 8, 2023

🦋 Changeset detected

Latest commit: 3c50999

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@faga295 faga295 marked this pull request as ready for review April 8, 2023 06:52
@ahabhgk ahabhgk changed the title feat: stats module reason feat: stats module reason type and userRequest Apr 9, 2023
packages/rspack/tests/Stats.test.ts Outdated Show resolved Hide resolved
packages/rspack/tests/Stats.test.ts Show resolved Hide resolved
Copy link
Collaborator

@ahabhgk ahabhgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ahabhgk ahabhgk added this pull request to the merge queue Apr 9, 2023
Merged via the queue into web-infra-dev:main with commit 32f822b Apr 9, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report]: Stats module reasons compared to webpack (userRequest and other fields missing)
2 participants