Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: finish all webpack test migration #2709

Merged
merged 7 commits into from
Apr 12, 2023
Merged

Conversation

IWANABETHATGUY
Copy link
Contributor

@IWANABETHATGUY IWANABETHATGUY commented Apr 11, 2023

Summary

This pr dependends these two pull request:

  1. test: finish *.test.js and *.basictest.js #2706
  2. test: long test.js #2708

Our target is run these four kinds of tests:

      "<rootDir>/test/*.test.js",
      "<rootDir>/test/*.basictest.js",
      "<rootDir>/test/*.longtest.js",
      "<rootDir>/test/*.unittest.js"

This pr finishes:

 "<rootDir>/test/*.unittest.js"

Here is a result after run pnpm --filter webpack-test test
image

Related issue (if exists)

Closed #2496

Types of changes

  • Docs change / Dependency upgrade
  • Bug fix
  • New feature / Improvement
  • Refactoring
  • Breaking change

Checklist

  • I have added changeset via pnpm run changeset.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Apr 11, 2023

⚠️ No Changeset found

Latest commit: 3a206db

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Apr 11, 2023
@IWANABETHATGUY IWANABETHATGUY changed the title Test/more webpack test test: finish all webpack test migration Apr 11, 2023
@IWANABETHATGUY IWANABETHATGUY force-pushed the test/more-webpack-test branch 3 times, most recently from 9208925 to 6434f9f Compare April 11, 2023 13:34
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review April 11, 2023 13:34
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Apr 12, 2023
Merged via the queue into main with commit 5bbc1f3 Apr 12, 2023
2 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the test/more-webpack-test branch April 12, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overall webpack test samples Migration
2 participants