Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 🤖 bump napi #2717

Merged
merged 9 commits into from
Apr 17, 2023
Merged

chore: 🤖 bump napi #2717

merged 9 commits into from
Apr 17, 2023

Conversation

IWANABETHATGUY
Copy link
Contributor

@IWANABETHATGUY IWANABETHATGUY commented Apr 11, 2023

Summary

  1. fix the issue caused by: fix(cli,napi-derive): re-export types from shared crate napi-rs/napi-rs#1531, this issue will cause napi-rs to generate different d.ts even if you start a blank pr and just rebuild the node-binding.
    image
  2. 'bitflags': napi has upgraded to latest bitfalgs@2.x.x, but there are still lots of dependencies still use bitflags@1.x.x, like clap, swc, this cause CI failed in version checking, bitflags@2.x.x still need some time to adopt in rust community, but we need upgrade napi-rs to latest to fix some bug. so bypass bitflags for now.

Related issue (if exists)

Types of changes

  • Docs change / Dependency upgrade
  • Bug fix
  • New feature / Improvement
  • Refactoring
  • Breaking change

Checklist

  • I have added changeset via pnpm run changeset.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Apr 11, 2023

⚠️ No Changeset found

Latest commit: 7087463

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Apr 11, 2023
@IWANABETHATGUY IWANABETHATGUY marked this pull request as draft April 16, 2023 16:07
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review April 17, 2023 05:46
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Apr 17, 2023
Merged via the queue into main with commit 59c42ba Apr 17, 2023
6 checks passed
@IWANABETHATGUY IWANABETHATGUY deleted the chore/bump-napi2 branch April 17, 2023 06:08
IWANABETHATGUY added a commit that referenced this pull request Apr 17, 2023
IWANABETHATGUY added a commit that referenced this pull request Apr 17, 2023
Revert "chore: 🤖 bump napi (#2717)"

This reverts commit 59c42ba.
siyou pushed a commit to siyou/rspack that referenced this pull request May 14, 2023
* chore: 🤖 bump napi

* chore: 🤖 update lock

* chore: 🤖 update lock

* chore: 🤖 update lock

* chore: 🤖 update lock

* chore: 🤖 update check_rust_depdency

* chore: 🤖 update comment

* fix: 🐛 cr issue

* chore: 🤖 byPasDepList
siyou pushed a commit to siyou/rspack that referenced this pull request May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants