Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): enable strictCommand & strictOption check #2723

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Conversation

hardfist
Copy link
Contributor

@hardfist hardfist commented Apr 12, 2023

Summary

  • check unknown command to avoid user passing unknown options or command
  • add rspack dev as a alias of rspack serve
    image

Related issue (if exists)

Types of changes

  • Docs change / Dependency upgrade
  • Bug fix
  • New feature / Improvement
  • Refactoring
  • Breaking change
    This remove the behavior of passing entry by post options which is not documented

Checklist

  • I have added changeset via pnpm run changeset.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Apr 12, 2023

🦋 Changeset detected

Latest commit: 97c4f51

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
Name Type
@rspack/cli Patch
benchmarkcase-rspack-react-refresh Patch
@rspack/postcss-loader Patch
@rspack/dev-client Patch
@rspack/dev-middleware Patch
@rspack/dev-server Patch
@rspack/plugin-html Patch
@rspack/plugin-minify Patch
@rspack/plugin-node-polyfill Patch
@rspack/core Patch
@rspack/binding-darwin-arm64 Patch
@rspack/binding-darwin-x64 Patch
@rspack/binding-linux-x64-gnu Patch
@rspack/binding-win32-x64-msvc Patch
@rspack/binding Patch
@rspack/fs Patch
webpack-test Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Apr 12, 2023
hyf0
hyf0 previously approved these changes Apr 12, 2023
@hardfist hardfist added this pull request to the merge queue Apr 12, 2023
Merged via the queue into main with commit c1df742 Apr 12, 2023
5 checks passed
@hardfist hardfist deleted the command-check branch April 12, 2023 06:43
@hyf0 hyf0 changed the title chore: enable strictCommand & strictOption check feat: enable strictCommand & strictOption check Apr 17, 2023
@hyf0 hyf0 changed the title feat: enable strictCommand & strictOption check feat(cli): enable strictCommand & strictOption check Apr 17, 2023
@github-actions github-actions bot mentioned this pull request Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants