Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): fix default NODE_ENV of command #2724

Merged
merged 1 commit into from
Apr 13, 2023
Merged

fix(cli): fix default NODE_ENV of command #2724

merged 1 commit into from
Apr 13, 2023

Conversation

hardfist
Copy link
Contributor

@hardfist hardfist commented Apr 12, 2023

馃 Generated by Copilot at 3b90dfc

Summary

馃摑馃殮馃殌

This pull request refactors and improves the @rspack/cli package by enabling strict mode, simplifying the build command, adding an alias for the serve command, and removing an unused argument. It also adds a changeset file to document the patch update.

Sing, O Muse, of the skillful changes wrought by the coder
Who refined the @rspack/cli package with wisdom and order
He removed the unused entry from the build command
And made it simpler and clearer for the users to understand

Walkthrough

  • Simplify build command by removing unused entry argument (link)
  • Add dev alias for serve command and define entry argument for it (link, link)
  • Refactor createCompiler method to take rspackCommand parameter and set process.env.NODE_ENV accordingly (link)
  • Enable strict mode for program property to fail on unknown commands or options (link)
  • Add changeset file to document patch update for @rspack/cli package (link)

@changeset-bot
Copy link

changeset-bot bot commented Apr 12, 2023

鈿狅笍 No Changeset found

Latest commit: f77815d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hardfist hardfist changed the title Fix command env fix(cli): fix default NODE_ENV of command Apr 12, 2023
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Apr 12, 2023
Copy link
Collaborator

@hyf0 hyf0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good poem

@hardfist hardfist added this pull request to the merge queue Apr 13, 2023
Merged via the queue into main with commit 511078f Apr 13, 2023
5 checks passed
@hardfist hardfist deleted the fix-command-env branch April 13, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants