Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: panic hook failed to restore after being suppressed #2734

Merged
merged 2 commits into from
Apr 12, 2023
Merged

Conversation

h-a-n-a
Copy link
Collaborator

@h-a-n-a h-a-n-a commented Apr 12, 2023

Summary

Fix where default panic hook failed being restored after being suppressed.

馃 Generated by Copilot at 49f8730

Optimize panic_hook_handler function in rspack_error crate. Simplify panic hook logic and remove unused thread-local storage to improve panic handling performance and correctness.

Related issue (if exists)

Walkthrough

馃 Generated by Copilot at 49f8730

  • Simplify and optimize the logic of setting and restoring the panic hook in catch_unwind.rs (link, link)
  • Remove the unused thread-local storage for the panic hook in catch_unwind.rs (link)

@changeset-bot
Copy link

changeset-bot bot commented Apr 12, 2023

馃 Changeset detected

Latest commit: 5f440b7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
Name Type
@rspack/binding Patch
@rspack/postcss-loader Patch
@rspack/core Patch
webpack-test Patch
@rspack/cli Patch
@rspack/dev-middleware Patch
@rspack/dev-server Patch
@rspack/plugin-html Patch
benchmarkcase-rspack-react-refresh Patch
@rspack/dev-client Patch
@rspack/plugin-minify Patch
@rspack/plugin-node-polyfill Patch
@rspack/binding-darwin-arm64 Patch
@rspack/binding-darwin-x64 Patch
@rspack/binding-linux-x64-gnu Patch
@rspack/binding-win32-x64-msvc Patch
@rspack/fs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Apr 12, 2023
@h-a-n-a h-a-n-a requested a review from ahabhgk as a code owner April 12, 2023 11:18
@h-a-n-a h-a-n-a added this pull request to the merge queue Apr 12, 2023
Merged via the queue into main with commit 27afffc Apr 12, 2023
6 checks passed
@h-a-n-a h-a-n-a deleted the fix/error branch April 12, 2023 11:43
@github-actions github-actions bot mentioned this pull request Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants