chore: remove continue-on-error from reusable-build #2743
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current setup is stable, let's fail the build if tests fail
Summary
馃 Generated by Copilot at 47d3a26
Remove
continue-on-error
option fromtest
job in.github/workflows/reusable-build.yml
. This ensures that the workflow will fail if any tests fail, which improves the quality and reliability of the rspack project.Related issue (if exists)
Walkthrough
馃 Generated by Copilot at 47d3a26
continue-on-error
option fromtest
job to ensure workflow fails on test failures (link)