Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove continue-on-error from reusable-build #2743

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

Boshen
Copy link
Contributor

@Boshen Boshen commented Apr 13, 2023

The current setup is stable, let's fail the build if tests fail

Summary

馃 Generated by Copilot at 47d3a26

Remove continue-on-error option from test job in .github/workflows/reusable-build.yml. This ensures that the workflow will fail if any tests fail, which improves the quality and reliability of the rspack project.

Related issue (if exists)

Walkthrough

馃 Generated by Copilot at 47d3a26

  • Remove continue-on-error option from test job to ensure workflow fails on test failures (link)

The current setup is stable, let's fail the build if tests fail
@changeset-bot
Copy link

changeset-bot bot commented Apr 13, 2023

鈿狅笍 No Changeset found

Latest commit: 47d3a26

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Apr 13, 2023
@Boshen Boshen added this pull request to the merge queue Apr 13, 2023
Merged via the queue into main with commit 5c48310 Apr 13, 2023
5 checks passed
@Boshen Boshen deleted the remove-continue-on-error branch April 13, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants